Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add custom handlers for swap-live-app #8937

Merged
merged 17 commits into from
Jan 27, 2025
Merged

feat: add custom handlers for swap-live-app #8937

merged 17 commits into from
Jan 27, 2025

Conversation

kallen-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 1:16pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 1:16pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 1:16pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 1:16pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jan 17, 2025
@kallen-ledger kallen-ledger marked this pull request as ready for review January 20, 2025 08:29
@kallen-ledger kallen-ledger requested a review from a team as a code owner January 20, 2025 08:29
Couto
Couto previously approved these changes Jan 22, 2025
View reviewed changes
liviuciulinaru
liviuciulinaru previously approved these changes Jan 22, 2025
View reviewed changes
@liviuciulinaru liviuciulinaru self-requested a review January 22, 2025 16:18
liviuciulinaru
liviuciulinaru previously approved these changes Jan 22, 2025
View reviewed changes
liviuciulinaru
liviuciulinaru previously approved these changes Jan 24, 2025
View reviewed changes
ejaycoleman
ejaycoleman previously approved these changes Jan 24, 2025
View reviewed changes
@kallen-ledger kallen-ledger merged commit 705a398 into develop Jan 27, 2025
41 checks passed
@kallen-ledger kallen-ledger deleted the feat/LIVE-10693 branch January 27, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liviuciulinaru liviuciulinaru liviuciulinaru approved these changes

@ejaycoleman ejaycoleman ejaycoleman approved these changes

@Couto Couto Couto approved these changes

Assignees

@kallen-ledger kallen-ledger

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kallen-ledger @Couto @ejaycoleman @liviuciulinaru