Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLM][Detox][Speculos] First Speculos delegate tests #8942

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[LLM][Detox][Speculos] First Speculos delegate tests #8942

wants to merge 2 commits into from
+413 −115

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Jan 17, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • LLM Speculos tests

📝 Description

First detox speculos delegate tests

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 2:11pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 2:11pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 2:11pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 2:11pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM ui Has changes in the design system library labels Jan 17, 2025
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_310_detox_speculos_delegate branch from 6c1b4ad to 354f88e Compare January 17, 2025 18:37
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_310_detox_speculos_delegate branch from 354f88e to 8147839 Compare January 20, 2025 09:00
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_310_detox_speculos_delegate branch from 8147839 to 5e2b60e Compare January 20, 2025 09:03
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review January 20, 2025 09:06
@abdurrahman-ledger abdurrahman-ledger requested review from a team as code owners January 20, 2025 09:06
mcoursier-ledger
mcoursier-ledger approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@mcoursier-ledger mcoursier-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoursier-ledger mcoursier-ledger mcoursier-ledger approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

@cgrellard-ledger cgrellard-ledger cgrellard-ledger approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@abdurrahman-ledger abdurrahman-ledger

Labels
mobile Has changes in LLM ui Has changes in the design system library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abdurrahman-ledger @cgrellard-ledger @ypolishchuk-ledger @mcoursier-ledger