🐛 (lld): Fix scroll on change device language #8953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
jiyuzhuang
previously approved these changes
Jan 20, 2025
| @@ -97,7 +97,7 @@ const DeviceLanguageInstallation: React.FC<Props> = ({ | |||
| <Text alignSelf="center" variant="h5Inter" mb={12}> | |||
| {t("deviceLocalization.deviceLanguage")} | |||
| </Text> | |||
| <Flex px={12} flex={1}> | |||
| <Flex px={12} flex={1} overflowY="scroll" height="100%"> | |||
aussedatlo
previously approved these changes
Jan 20, 2025
jdabbech-ledger
dismissed stale reviews from aussedatlo, ofreyssinet-ledger, and jiyuzhuang
via
8e68e45
jdabbech-ledger
force-pushed
the
fix/live-14690-scroll-languages
branch
from
818dded to
8e68e45
Compare
ofreyssinet-ledger
approved these changes
Jan 20, 2025
jiyuzhuang
approved these changes
Jan 20, 2025
aussedatlo
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Fix scroll on change device language
live-14690.mp4
live-14690.mp4
❓ Context
🧐 Checklist for the PR Reviewers