feat(coin:xrp): apply api change on operations #8987
Merged
+460
−279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
live-github-bot
bot
added
desktop
live-github-bot
bot
removed
desktop
hedi-edelbloute
previously approved these changes
Jan 29, 2025
|
@hedi-edelbloute I fixed the comments |
hedi-edelbloute
previously approved these changes
Jan 30, 2025
hedi-edelbloute
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, this is a big PR.
I changed the API of "operations" so, it impacted the code on all coins that implements the coin framework. Specifically I changed the semantic of "operations" so that it returns all operations, without pagination. In the future we may paginate using a proper token described in this document https://ledgerhq.atlassian.net/wiki/x/XIGeRAE
For stellar/tezos/xrp coins: I also changed signature of "logic" layer so that the token used for iteration is string not a number. The value of the token is a stringified json representation of the token returned by the underlying "network" layer. It's returned by the listOperations so that it could be reused as input in future implementation.
For stellar and tezos, the "api" is adapted for compilation but not yet ready to use, we'll have 2 respective separate PR for that:
For XRP specifically,
orderparameter as a workaroud for LIVE-16705integrations tests: https://github.com/LedgerHQ/ledger-live/actions/runs/13056449704