lib_ux_sync: First version #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #613 +/- ##
=======================================
Coverage 59.85% 59.85%
=======================================
Files 12 12
Lines 1684 1684
=======================================
Hits 1008 1008
Misses 676 676
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xchapron-ledger
force-pushed
the
xch/nbgl_use_case_sync
branch
3 times, most recently
from
dfd3050
to
9af7813
Compare
xchapron-ledger
changed the title
xchapron-ledger
force-pushed
the
xch/nbgl_use_case_sync
branch
2 times, most recently
from
e54ea8c
to
b2b851f
Compare
nroggeman-ledger
requested changes
Apr 11, 2024
xchapron-ledger
force-pushed
the
xch/nbgl_use_case_sync
branch
from
b2b851f
to
2b16f3b
Compare
nroggeman-ledger
approved these changes
Apr 11, 2024
cedelavergne-ledger
approved these changes
Apr 11, 2024
|
@xchapron-ledger @tdejoigny-ledger integration tests done in the Rust SDK with the Rust boilerplate. Looks good to me. Go for merge. |
xchapron-ledger
force-pushed
the
xch/nbgl_use_case_sync
branch
from
2b16f3b
to
cbe3ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lib_ux_sync: First version
Can be tested on API_LEVEL_15 (Stax 1.4.0-rc3 on this branch: https://github.com/LedgerHQ/ledger-secure-sdk/tree/xch/test-nbgl-sync-api-level-15
Example of usage on app-boilerplate can be seen here: LedgerHQ/app-boilerplate#120
Changes include