Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBGL extensions for future UX screens #827

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to add some features to NBGL to enable creating (or extending) future Bolos UX screens.
These extensions are:

  • Support animation in centered info (instead icon)
  • Support dual rouded buttons in footer
  • Support an additionnal icon in some header
  • Support sub-text in spinner
  • Support ability to change validation icon type in PinPad with arrow instead of check

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • [*] New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.49%. Comparing base (d59b21f) to head (59f9125).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #827   +/-   ##
=======================================
  Coverage   35.49%   35.49%           
=======================================
  Files          13       13           
  Lines        1606     1606           
=======================================
  Hits          570      570           
  Misses       1036     1036           
Flag Coverage Δ
unittests 35.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger force-pushed the nbgl-extensions-for-charon branch from ab0f99c to c940ec1 Compare November 25, 2024 10:37
@nroggeman-ledger nroggeman-ledger force-pushed the nbgl-extensions-for-charon branch from c940ec1 to 8976ff9 Compare November 28, 2024 08:35
@nroggeman-ledger nroggeman-ledger merged commit e8f68a6 into master Nov 29, 2024
189 checks passed
@nroggeman-ledger nroggeman-ledger deleted the nbgl-extensions-for-charon branch November 29, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants