Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the info list property in nbgl_tipBox_t non-const #828

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

apaillier-ledger
Copy link
Contributor

Description

To make it easier to use, since it wasn't a pointer to a struct, but rather the struct itself.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger apaillier-ledger marked this pull request as ready for review November 26, 2024 09:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.49%. Comparing base (930d28e) to head (5a77ca7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #828   +/-   ##
=======================================
  Coverage   35.49%   35.49%           
=======================================
  Files          13       13           
  Lines        1606     1606           
=======================================
  Hits          570      570           
  Misses       1036     1036           
Flag Coverage Δ
unittests 35.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apaillier-ledger apaillier-ledger merged commit d59b21f into master Nov 26, 2024
189 checks passed
@apaillier-ledger apaillier-ledger deleted the unconst_infolist_in_nbgl_tipbox branch November 26, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants