-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dark theme #605
feat: dark theme #605
Conversation
@atsuyaw, thank you very much! It's a big pull request and will take me time to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be duplicated _dk-*.scss
files. The only new SCSS file should be dark-theme.css
which is a copy of theme.css
but with different values for customizable variables.
Thanks for helping! |
@igor-baiborodine Now I made a modification on the colors. Would you check again? |
@atsuyaw, here is the Bilberry Sandbox deployed using your branch. You can compare it with the Bilberry Sandbox deployed using the latest release.
@Lednerb, @Sp-cy, if you have time, can you check the proposed color scheme for the dark theme mode? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atsuyaw, please see my comment above.
@atsuyaw, the Bilberry Sandox was updated with your latest commits. The only issue I see now is the flickering that happens when changing pages in the dark mode. Screencast.from.2023-11-13.05.53.09.PM.webm |
@igor-baiborodine, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, the switching mechanism has been reconstructed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the sandbox, and there is no flickering, but it's going back to the light mode when I change a page after selecting the dark mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the Sandbox, and everything works fine, but there is a minor issue with showing js/check-theme-prefer.js
in the top left corner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huuum, i saw it on the sandbox, however this issue wasn't observed in my local environment. Now i'm trying fix this line.
Let me check on the sandbox. I am sorry for inconvenience...!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atsuyaw, great job! Thank you!
Resolves #185, resolves #525 (relational topics: #315, #526).
Feel free to post any comments including on the default color scheme ;)