Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dark theme #605

Merged
merged 30 commits into from
Dec 6, 2023
Merged

feat: dark theme #605

merged 30 commits into from
Dec 6, 2023

Conversation

atsuyaw
Copy link
Contributor

@atsuyaw atsuyaw commented Oct 22, 2023

Resolves #185, resolves #525 (relational topics: #315, #526).

Feel free to post any comments including on the default color scheme ;)

image

@atsuyaw atsuyaw changed the title feat: implementation of dark theme feat: dark theme Oct 22, 2023
@igor-baiborodine
Copy link
Collaborator

@atsuyaw, thank you very much! It's a big pull request and will take me time to review.

@igor-baiborodine igor-baiborodine self-requested a review October 22, 2023 18:40
Copy link
Collaborator

@igor-baiborodine igor-baiborodine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be duplicated _dk-*.scss files. The only new SCSS file should be dark-theme.css which is a copy of theme.css but with different values for customizable variables.

v4/README.md Outdated Show resolved Hide resolved
v4/layouts/partials/header.html Outdated Show resolved Hide resolved
v4/layouts/partials/js.html Outdated Show resolved Hide resolved
v4/assets/js/dark-toggle.js Outdated Show resolved Hide resolved
v4/assets/js/dark-toggle.js Outdated Show resolved Hide resolved
v4/assets/js/dark-toggle.js Outdated Show resolved Hide resolved
v4/assets/js/dark-toggle.js Outdated Show resolved Hide resolved
v4/assets/js/dark-toggle.js Outdated Show resolved Hide resolved
v4/layouts/partials/css.html Outdated Show resolved Hide resolved
@atsuyaw
Copy link
Contributor Author

atsuyaw commented Nov 3, 2023

Thanks for helping!
Let me try to "polish" the colors prior to merging.

@atsuyaw
Copy link
Contributor Author

atsuyaw commented Nov 3, 2023

@igor-baiborodine Now I made a modification on the colors. Would you check again?
Thank you!

@igor-baiborodine
Copy link
Collaborator

igor-baiborodine commented Nov 5, 2023

@atsuyaw, here is the Bilberry Sandbox deployed using your branch. You can compare it with the Bilberry Sandbox deployed using the latest release.

@Lednerb, @Sp-cy, if you have time, can you check the proposed color scheme for the dark theme mode?

image

image

Copy link
Collaborator

@igor-baiborodine igor-baiborodine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atsuyaw, please see my comment above.

@Lednerb
Copy link
Owner

Lednerb commented Nov 6, 2023

Hello all,

thanks for your great work!

The colors are OK for me in general, but I think some adjustments should be added:

grafik

1: The lighter color coming from above will add some more contrast
2: I think the meta line should also have a bit more contrast, like the font in the article footer
3: The background is too bright, maybe more like GitHub inline code in the dark mode?

grafik

Additionally the search box should also be adjusted before the final merge.

And hover states on links are not readable:
grafik


The color theme switcher is very neat!

v4/layouts/partials/css.html Outdated Show resolved Hide resolved
@igor-baiborodine
Copy link
Collaborator

@atsuyaw, the Bilberry Sandox was updated with your latest commits. The only issue I see now is the flickering that happens when changing pages in the dark mode.

Screencast.from.2023-11-13.05.53.09.PM.webm

@atsuyaw
Copy link
Contributor Author

atsuyaw commented Nov 14, 2023

@igor-baiborodine,
Thanks for your cooperation and pointing out!
I need to modify also the giscus theme behavior with the global dark mode.

Copy link
Collaborator

@igor-baiborodine igor-baiborodine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The connection line should be the same color, i.e., the same as in the upper part.

image

There is still the issue of flickering when using the Chrome and Opera browsers. In Firefox, it works fine, though.

v4/README.md Outdated Show resolved Hide resolved
@atsuyaw
Copy link
Contributor Author

atsuyaw commented Nov 26, 2023

Here, the switching mechanism has been reconstructed.
Please try to check the improvement; the Network throttling mode in inspecting tools of Chrome was useful in my cording.

Copy link
Collaborator

@igor-baiborodine igor-baiborodine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the sandbox, and there is no flickering, but it's going back to the light mode when I change a page after selecting the dark mode.

https://deploy-preview-45--bilberry-sandbox.netlify.app/

v4/tests/exampleSite/config.toml Outdated Show resolved Hide resolved
v4/layouts/partials/check-theme-prefer.html Outdated Show resolved Hide resolved
@igor-baiborodine igor-baiborodine self-requested a review December 5, 2023 13:46
Copy link
Collaborator

@igor-baiborodine igor-baiborodine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the Sandbox, and everything works fine, but there is a minor issue with showing js/check-theme-prefer.js in the top left corner.

https://deploy-preview-45--bilberry-sandbox.netlify.app/

image

Copy link
Contributor Author

@atsuyaw atsuyaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huuum, i saw it on the sandbox, however this issue wasn't observed in my local environment. Now i'm trying fix this line.
Let me check on the sandbox. I am sorry for inconvenience...!

@igor-baiborodine igor-baiborodine self-requested a review December 6, 2023 14:09
Copy link
Collaborator

@igor-baiborodine igor-baiborodine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atsuyaw, great job! Thank you!

@igor-baiborodine igor-baiborodine merged commit edd20eb into Lednerb:master Dec 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode Day/Night mode support
3 participants