Containerise, add dockerfile and job to push to dockerhub #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencomp
requested changes
Jan 30, 2025
Containerfile
Outdated
Comment on lines
6
to
12
| # Install system dependencies | ||
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
| git \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Clone the repository | ||
| RUN git clone https://github.com/LeidenUniversityLibrary/abnormal-hieratic-indexer.git /app |
There was a problem hiding this comment.
The code is in this repository, so we don't need to clone from GitHub :)
Suggested change
| # Install system dependencies | |
| RUN apt-get update && apt-get install -y --no-install-recommends \ | |
| git \ | |
| && rm -rf /var/lib/apt/lists/* | |
| # Clone the repository | |
| RUN git clone https://github.com/LeidenUniversityLibrary/abnormal-hieratic-indexer.git /app | |
| COPY . /app |
Instead of copying everything (including .github), we could be more selective in the COPY command, or include .dockerignore.
Comment on lines
+14
to
+17
| # Install dependencies based on pyproject.toml | ||
| RUN pip install --upgrade pip && pip install build | ||
| RUN python -m build | ||
| RUN pip install dist/*.whl # or dist/*.tar.gz if it generates a source distribution |
There was a problem hiding this comment.
We also build and publish the package on PyPI in a different workflow, so we could pip install abnormal-hieratic-indexer. That workflow does only run when a release is published, so it may not be what we want.
| RUN pip install --upgrade pip && pip install build | ||
| RUN python -m build | ||
| RUN pip install dist/*.whl # or dist/*.tar.gz if it generates a source distribution | ||
|
|
There was a problem hiding this comment.
It would be nice to have an ENTRYPOINT or CMD (or both?), to show what we intend the image to be used for. It would also allow for a shorter docker run command.
added 2 commits
January 31, 2025 08:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's always nice to have it containerised.
Also the python version/dependencies required does not seem to work easily on the host server, we can decouple those requirements by containerisation