Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telegram icon #238

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Telegram icon #238

merged 7 commits into from
Sep 18, 2024

Conversation

IPdotSetAF
Copy link
Contributor

@IPdotSetAF IPdotSetAF commented Sep 16, 2024 •
edited
Loading

Fixed Telegram icon

Icon Details

Icon ID Icon
telegram telegram

Notes

Checklist

  • Added icon(s) to the appropriate directory
  • Updated documentation with the new icon(s)
  • Verified the icon(s) display correctly
  • If the icon has light and dark, verified the auto switch works correctly
  • The Svg does not contain any sort of strokes

@LelouchFR
Copy link
Owner

I cannot go on my computer rn, going to check it when I can...

@LelouchFR
Copy link
Owner

Please update your branch to resolve the conflict

@IPdotSetAF
Copy link
Contributor Author

The conflict is resolved. 😉

LelouchFR
LelouchFR requested changes Sep 18, 2024
View reviewed changes
Copy link
Owner

@LelouchFR LelouchFR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you take out the xml tag, so it renders as an svg through the api ?

after that if should be all good ig

LelouchFR
LelouchFR approved these changes Sep 18, 2024
View reviewed changes
Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LelouchFR LelouchFR merged commit 21fced9 into LelouchFR:main Sep 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LelouchFR LelouchFR LelouchFR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Telegram icon not working
2 participants
@IPdotSetAF @LelouchFR