Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add barbajs, frankenphp & milvus icons #250

Merged
merged 3 commits into from
Sep 22, 2024
Merged

add barbajs, frankenphp & milvus icons #250

merged 3 commits into from
Sep 22, 2024

Conversation

ghost
Copy link

@ghost ghost commented Sep 21, 2024 •
edited by ghost
Loading

Add New Icon(s)

Icon Details

Icon ID Icon
barbajs barbajs
frankenphp frankenphp-dark frankenphp-light
milvus milvus-dark milvus-light

Notes

Checklist

  • Added icon(s) to the appropriate directory
  • Updated documentation with the new icon(s)
  • Verified the icon(s) display correctly
  • If the icon has light and dark, verified the auto switch works correctly
  • The Svg does not contain any sort of strokes

LelouchFR
LelouchFR requested changes Sep 21, 2024
View reviewed changes
Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strokes in the barbajs logo, after that it should be all good

@ghost
Copy link
Author

ghost commented Sep 22, 2024

strokes in the barbajs logo, after that it should be all good

mb, it's good to go now

@ghost ghost requested a review from LelouchFR September 22, 2024 07:15
LelouchFR
LelouchFR approved these changes Sep 22, 2024
View reviewed changes
Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LelouchFR LelouchFR merged commit 8fc105f into LelouchFR:main Sep 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NEW ICON]: Milvus [NEW ICON]: Barba.js [NEW ICON]: FrankenPHP
1 participant
@LelouchFR