Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated css logo to the latest version #291

Merged
merged 4 commits into from
Nov 23, 2024
Merged

Conversation

Jeesson
Copy link
Contributor

@Jeesson Jeesson commented Nov 20, 2024

Updated CSS Icon(s)

Introduced a new official logo for CSS, replacing the outdated CSS3 shield logo. The updated logo, designed by Javi Aguilar in collaboration with the CSS-Next Community Group, represents CSS as a whole rather than a specific version. It aligns visually with other web language logos like JS, TS, and WA, featuring modern design elements and the iconic "rebeccapurple" color.

Icon Details

Icon ID Icon
css css

Notes

Checklist

  • Added icon(s) to the appropriate directory
  • Verified the icon(s) display correctly
  • Updated documentation with the new icon(s)
  • If the icon has light and dark, verified the auto switch works correctly
  • The Svg does not contain any sort of strokes

@LelouchFR
Copy link
Owner

I would love to, but that the logo has one corner with no radius... I don't know how it should be implemented :/

I don't think it should be a problem to have an icon that doesn't respect this.

@Jeesson
Copy link
Contributor Author

Jeesson commented Nov 22, 2024

I understand your concern, but I believe it would be more authentic to leave one side unrounded. This way, at least one icon can visually convey its connection to the style, even if it doesn’t strictly follow the radius rule. That said, I’ve adjusted it to align with your feedback nonetheless.

Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you're right @Jeesson the icon actually looks better with the one corner at 0 radius... I'm sorry :[

I think maybe just make one version css.svg and remove css-[auto, dark, light].svg.

@Jeesson
Copy link
Contributor Author

Jeesson commented Nov 22, 2024

I might have misunderstood the purpose of the auto mode, so I left it in just in case. However, it can be removed if you think it’s unnecessary — what do you think?

@LelouchFR
Copy link
Owner

I might have misunderstood the purpose of the auto mode, so I left it in just in case. However, it can be removed if you think it’s unnecessary — what do you think?

I think making it rebecca purple would be better :) then it will be all good I guess

@LelouchFR
Copy link
Owner

@Jeesson which one do you prefer ?
1:
image
2:
image

@Jeesson
Copy link
Contributor Author

Jeesson commented Nov 23, 2024

The first option is definitely better — it adds uniqueness to the icon, just like with wasm. There’s nothing wrong with that, right?

@LelouchFR
Copy link
Owner

The first option is definitely better — it adds uniqueness to the icon, just like with wasm. There’s nothing wrong with that, right?

I completly agree with you :)

Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LelouchFR LelouchFR merged commit 4a6dcd7 into LelouchFR:main Nov 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants