Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added shadcn icon, a very popular css library #331

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Conversation

hiyodev
Copy link
Contributor

@hiyodev hiyodev commented Feb 9, 2025

Add New Icon(s)

Icon Details

Icon ID Icon
shadcn-auto image
shadcn-dark image
shadcn-light image

Notes

  • There's a PR for it here but seems like it's abandoned: closes add shadcn icon #298
  • I took the original SVG from shadcn's website and modified it in Figma to remove strokes and recreate the exact same svg icons. I made sure it matched pixel to pixel to the original icons.
  • Tested in light / dark, svg-auto works as expected.

Please let me know if there's any issues, there's a number of Frontend Icons that I really want to add to your repo.

Checklist

  • Added icon(s) to the appropriate directory
  • Updated documentation with the new icon(s)
  • Verified the icon(s) display correctly
  • If the icon has light and dark, verified the auto switch works correctly
  • The Svg does not contain any sort of strokes

Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the README file using the ./.github/readme-format.sh script ?

@hiyodev
Copy link
Contributor Author

hiyodev commented Feb 11, 2025

can you update the README file using the ./.github/readme-format.sh script ?

Sure, give me a moment I will fix the issues.

@hiyodev hiyodev requested a review from LelouchFR February 11, 2025 01:11
Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LelouchFR LelouchFR merged commit 9eccccb into LelouchFR:main Feb 12, 2025
2 of 3 checks passed
@Denisskas
Copy link
Contributor

@LelouchFR I think need to revert the commit.
chrome_RGAFcigLlO

LelouchFR added a commit that referenced this pull request Feb 12, 2025
LelouchFR added a commit that referenced this pull request Feb 12, 2025
@LelouchFR
Copy link
Owner

@hiyodev Please make another PR for shadcn else I will make it...

For using the project, please, use Linux (Or WSL) for the script. (I will do a script for windows when I can).

@hiyodev
Copy link
Contributor Author

hiyodev commented Feb 12, 2025

@LelouchFR , sure give me a moment, sorry about the readme issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants