Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏋️‍♂️Putting the image on a serious diet (v4.0.0) #13

Merged
merged 78 commits into from
Jan 3, 2025

Conversation

ABUCKY0
Copy link
Collaborator

@ABUCKY0 ABUCKY0 commented Dec 30, 2024

  • ⚙️Switch to Alpine Linux to save space from ubuntu being a fatty (Thanks @Jerrylum and https://github.com/Jerrylum/pros-build)
  • 🎭 Implement Dockerfile staging to reduce the total number of pulled layers and the toolchain taking up 2GB with it's two 1GB layers)
  • 🔪 Trim the fat off of the ARM Toolchain to further reduce the file size.

This decreased the file size from 3.69 (nice) gigabytes to 1.04 gigabytes 446 MB.

@ABUCKY0 ABUCKY0 changed the title 🏋️‍♂️Putting the image on a serious diet 🏋️‍♂️Putting the image on a serious diet (v4.0.0) Jan 2, 2025
@ABUCKY0 ABUCKY0 marked this pull request as ready for review January 2, 2025 03:47
@ABUCKY0
Copy link
Collaborator Author

ABUCKY0 commented Jan 2, 2025

Closes #6

@ABUCKY0 ABUCKY0 added the enhancement New feature or request label Jan 2, 2025
@ABUCKY0 ABUCKY0 linked an issue Jan 2, 2025 that may be closed by this pull request
@ABUCKY0 ABUCKY0 self-assigned this Jan 2, 2025
@ABUCKY0 ABUCKY0 requested a review from meisZWFLZ January 2, 2025 03:50
ABUCKY0 and others added 6 commits January 1, 2025 22:24
* ♻️ Improved run instruction
- Makes it a little more readable by using heredoc
- Pipes tar.xz to tar to prevent writing it to disk
- Uses brace expansion where possible to shorten
- Don't even write some of the unnecessary files to disk

* split toolchain downloading into seperate RUN command for caching efficency and convert all tar --exclude params to their original rm/find forms.

* Fix broken gcc rm command for /bin/arm-none-eabi-gcc-13.3.1

* fix gcc-13.3.1 removal

* delete long_toolchain variable

* 💄 Remove extra whitespace

* remove package installation from get-dependencies since it's already redone in runner stage and the packages aren't used in the get-deps stage

---------

Co-authored-by: ABUCKY0 <[email protected]>
Copy link
Member

@meisZWFLZ meisZWFLZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ABUCKY0 ABUCKY0 merged commit 1a3f11c into main Jan 3, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim parts of the toolchain.
2 participants