Bugfixes and improvements

Lezurex · Aug 8, 2021 · 9a97d5f · 9a97d5f
1 parent c14d194
commit 9a97d5f
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 21 deletions.
diff --git a/.idea/.gitignore b/.idea/.gitignore
diff --git a/.idea/sonarlint/issuestore/index.pb b/.idea/sonarlint/issuestore/index.pb
diff --git a/src/main/java/com/lezurex/githubversionchecker/ReleaseVersion.java b/src/main/java/com/lezurex/githubversionchecker/ReleaseVersion.java
@@ -32,18 +32,18 @@ public ReleaseVersion(int major, int minor, int patch) {
     }
 
     public ReleaseVersion(String versionString) {
-
+        parseVersionString(versionString);
     }
 
     private void parseVersionString(String s) {
         final Pattern pattern = Pattern.compile("[vV]?(\\d+)\\.?(\\d+)?\\.?(\\d+)?");
         final Matcher matcher = pattern.matcher(s);
 
         if (matcher.find()) {
-            for (int i = 1; i < matcher.groupCount(); i++) {
-                if (i == 1) this.major = Integer.parseInt(matcher.group());
-                if (i == 2) this.minor = Integer.parseInt(matcher.group());
-                if (i == 3) this.patch = Integer.parseInt(matcher.group());
+            for (int i = 1; i <= matcher.groupCount(); i++) {
+                if (i == 1) this.major = Integer.parseInt(matcher.group(i));
+                if (i == 2) this.minor = Integer.parseInt(matcher.group(i));
+                if (i == 3) this.patch = Integer.parseInt(matcher.group(i));
             }
         } else throw new InvalidVersionString(s);
     }

diff --git a/src/test/java/com/lezurex/githubversionchecker/GithubVersionCheckerTest.java b/src/test/java/com/lezurex/githubversionchecker/GithubVersionCheckerTest.java
@@ -24,4 +24,14 @@ void setupInvalidRepo() {
         assertThrows(RepoNotFoundException.class, () -> new GithubVersionChecker("Lezurex", "doesnotexist", releaseVersion), "Repo validation di not fail!");
     }
 
+    @Test
+    @DisplayName("Check with outdated version")
+    void checkOutdated() {
+        ReleaseVersion releaseVersion = new ReleaseVersion("0.0.1");
+        GithubVersionChecker githubVersionChecker = new GithubVersionChecker("VoxCrafterLP", "JumpRace", releaseVersion);
+        CheckResult checkResult = githubVersionChecker.check();
+        assertEquals(VersionState.OUTDATED, checkResult.getVersionState(), "Version state is not outdated!");
+        assertTrue(checkResult.getPageLink().endsWith(checkResult.getVersion().toString()), "End of release URL does not match version!");
+    }
+
 }