Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs and add simple test for readme encoding examples #107

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

wilwade
Copy link
Member

@wilwade wilwade commented Jan 5, 2024

Problem

Docs were wrong from a long time ago per ironSource#100

Solution

Updated the docs and added a simple test

Closes #106

Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! 👍

@wilwade wilwade merged commit e0f1ebd into main Jan 9, 2024
1 check passed
@wilwade wilwade deleted the fix/incorrect-docs-106 branch January 9, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RLE example does not work - 'bitWidth' does not exist in type 'FieldDefinition'
3 participants