-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 03-working-with-data.md #322
Conversation
replaced row in title with record for image 2 of 2 but also need higher quality resolution to zoom in
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-322 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-11-20 20:25:30 +0000 |
Should I make the screen shot after updating to 3.7? I'm in 3.6 @ostephens |
Pausing now to see if it all loads correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new images you've added are JPG, but the existing images are PNG format and markdown in the lesson points to the PNG images.
I can't find any specific advice on which image format to use in carpentries lessons and either would work, but PNG seems to be the standard and what we've used elsewhere in the lessons - so can you remove the JPG versions and create PNG versions to replace the existing images?
part of PR#322
need png file
png file required
Hi Owen, I changed the files to png. |
Auto-generated via {sandpaper} Source : 37046ac Branch : main Author : Owen Stephens <[email protected]> Time : 2023-11-22 15:17:29 +0000 Message : Merge pull request #322 from LibraryCarpentry/jas58-patch-1 Update 03-working-with-data.md
Auto-generated via {sandpaper} Source : 9aeaea0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-11-22 15:18:35 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 37046ac Branch : main Author : Owen Stephens <[email protected]> Time : 2023-11-22 15:17:29 +0000 Message : Merge pull request #322 from LibraryCarpentry/jas58-patch-1 Update 03-working-with-data.md
Auto-generated via {sandpaper} Source : 9aeaea0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-11-22 15:18:35 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 37046ac Branch : main Author : Owen Stephens <[email protected]> Time : 2023-11-22 15:17:29 +0000 Message : Merge pull request #322 from LibraryCarpentry/jas58-patch-1 Update 03-working-with-data.md
Auto-generated via {sandpaper} Source : 9aeaea0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-11-22 15:18:35 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 37046ac Branch : main Author : Owen Stephens <[email protected]> Time : 2023-11-22 15:17:29 +0000 Message : Merge pull request #322 from LibraryCarpentry/jas58-patch-1 Update 03-working-with-data.md
replaced 'row' in figure title with 'record' for image 2 of 2 but also need higher quality resolution to zoom in
Suggested by co-instructor Sept 2023.
still looking for how to update the image