Set bandwidth minimums to 1M for CRM/NMS integrations #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchac
changed the title
Update LibreQoS.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the LibreQoS integrations set the minimum rates of Circuits to match their maximum rates. The problem with this is that that guarantees HTB over-subscription - leading to Nodes for APs and Sites going over their limits regularly. To fix this, this PR sets all circuits (except infrastructure) to a minimum of 1 Mbps. That way, it becomes extremely unlikely to oversubscribe the HTB minimums.
This not only prevents APs and Sites from exceeding maximums, it also allows for more steady throughput to those nodes.