Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Receipts Page #53

Merged
merged 9 commits into from
Jul 24, 2024
Merged

My Receipts Page #53

merged 9 commits into from
Jul 24, 2024

Conversation

SamuelLiSiyuan
Copy link
Collaborator

@SamuelLiSiyuan SamuelLiSiyuan commented Jul 19, 2024

My Receipts Page UI and logic,

  • My benefit on bottom bar is now changed to my receipts page
  • Dropdown filter by used cards and purchase type
  • Addtion infomation field for each receipt
  • Record receipt button at the bottom (not functional)

myReceiptsPage

@SamuelLiSiyuan
Copy link
Collaborator Author

What should be on the View Receipt Page?

Copy link
Collaborator

@NandiniMeh NandiniMeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the View Receipt page, it should just be the receipt itself, and the information related to it (like date, purchase type, amount, card used etc) not sure if anyone else is working on this though @rachellefontanilla @sophiec103 @jeanniezhang

This is regarding the button for "view" right

@SamuelLiSiyuan
Copy link
Collaborator Author

date, purchase type, amount, card used

Since all this information is already shown on this page, if no more detailed information needs to be presented, I am not sure if it is necessary to have a separate page for it.

Anyway, if no one is working on the view receipt page, I can take it.

@NandiniMeh
Copy link
Collaborator

date, purchase type, amount, card used

Since all this information is already shown on this page, if no more detailed information needs to be presented, I am not sure if it is necessary to have a separate page for it.

Anyway, if no one is working on the view receipt page, I can take it.

hmmm thats a good point. maybe a way to see the image would be good? any suggestions would be great. like for example, if there's a way to get the image of the receipt to be saved to gallery or something

@LideLinusZhang LideLinusZhang marked this pull request as draft July 24, 2024 00:27
@LideLinusZhang LideLinusZhang marked this pull request as ready for review July 24, 2024 01:26
…yReceiptsPage

# Conflicts:
#	app/src/main/java/edu/card/clarity/presentation/navigation/BottomNavGraph.kt
@SamuelLiSiyuan SamuelLiSiyuan merged commit 0af2334 into main Jul 24, 2024
2 checks passed
@SamuelLiSiyuan SamuelLiSiyuan deleted the myReceiptsPage branch July 24, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receipts Page (Connect to Backend) My Receipts Page UI
3 participants