Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public method to get facade and get IPP Instance to Batch Sync #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ingluife
Copy link

@ingluife ingluife commented Jul 29, 2019

Hi guys, I'll describe the changes in this PR:

  • public function getResourceFacade():
    This method actually is protected and I need to get the Facade for know the QuickBooks Resource name.

  • Remove public function getQuickBooksArray();:
    This method already is in the SyncsToQuickBooks.php Trait as an abstract protected method and this ambiguity generates an issue.

  • Add getResourceName Method:
    This method is required to know the Resource name from its Facade.

  • Add getQuickBooksInstanceToBatch method:
    This method returns a QuickBooks instance to synchronize by batch

  • Update quickbooks/v3-php-sdk package to version 5.0.5:
    This update solves the TLS 1.3 Compatibility and maintains TLS 1.2 compatibility

  • Add getQuickBooksSyncTokenAttribute method:
    This change adds the possibility of storing the QuickBooks SyncToken attribute in all entities after each operation (Insert | Update).

  • Change self to static static::cookieIsValid():
    This change is to allow extend this class and override the Cookie Validation

  • Add PaymentMethod Facade:
    This is a provisional Facade while is incorporated into Official QuickBooksOnline Package

  • Add PaymentMethod Resource:
    This is the Payment Method Resource

  • Remove method return type getDataService(): DataService QuickBooksAuthenticator file:
    This change is to allow to override the getDataService method to extend the DataService class

Tranks.

@ingluife ingluife force-pushed the feature/create-batch-sync branch 13 times, most recently from 08d37cc to 91fa750 Compare August 2, 2019 16:16
@ingluife ingluife force-pushed the feature/create-batch-sync branch 2 times, most recently from 0ace005 to d93ac9b Compare August 14, 2019 21:20
@ingluife ingluife force-pushed the feature/create-batch-sync branch 4 times, most recently from a0b17ba to b583a46 Compare November 8, 2019 13:49
@ingluife ingluife force-pushed the feature/create-batch-sync branch 3 times, most recently from 807544a to 534814f Compare November 21, 2019 21:33
@ingluife ingluife force-pushed the feature/create-batch-sync branch from 534814f to bb4265b Compare November 21, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant