Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow linear to be consumed by nvFuser by default #1371

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+5 −0
Open

Allow linear to be consumed by nvFuser by default #1371

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9032bf1
Allow linear to be consumed by nvFuser by default
IvanYashchuk Oct 30, 2024
76622ff
Update thunder/executors/nvfuserex_impl.py
IvanYashchuk Oct 30, 2024
dbe0857
Merge remote-tracking branch 'upstream/main' into use-linear-in-nvfuser
IvanYashchuk Nov 7, 2024
3e816f3
Make test_cse_rematerialization_nvfuser_cuda_None pass
IvanYashchuk Nov 7, 2024
4a6f358
Merge branch 'main' into use-linear-in-nvfuser
wujingyue Nov 14, 2024
59ec695
Enable linear only for nvFuser 0.2.23+
IvanYashchuk Nov 18, 2024
296ac72
Merge remote-tracking branch 'upstream/main' into use-linear-in-nvfuser
IvanYashchuk Nov 18, 2024
f6596e2
Merge branch 'main' into use-linear-in-nvfuser
kiya00 Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions thunder/executors/nvfuserex_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2240,6 +2240,8 @@ def map_inside_replacement(x: Any) -> None:

def _linear_check(a: TensorProxy, b: TensorProxy, bias: TensorProxy | None) -> bool:
enable_linear: None | bool = get_compile_option("nv_enable_linear", "Enable nvFuser linear.")
if enable_linear is None:
enable_linear = True
if not enable_linear:
return False
riccardofelluga marked this conversation as resolved.
Show resolved Hide resolved
# Verify linear inputs and bias (optional) are supported tensors.
Expand Down
1 change: 1 addition & 0 deletions thunder/tests/test_nvfuser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ def test_cse_rematerialization(executor, device, _):
disable_torch_autograd=True,
executors=executor.executors_list(),
nv_enable_bookend=False,
nv_enable_linear=False,
)
compiled_func(x, y)

Expand Down
Loading