Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test HF's implementation of Phi 3 model #1439

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Test HF's implementation of Phi 3 model #1439

merged 6 commits into from
Nov 18, 2024

Conversation

IvanYashchuk
Copy link
Collaborator

This PR adds a test to verify that the computed cross-entropy loss matches between HF's implementation and application of Thunder on this model.

Ref. #1278.

@IvanYashchuk IvanYashchuk added the huggingface For supporting HF models label Nov 14, 2024
This was referenced Nov 14, 2024
Closed
Closed
riccardofelluga
riccardofelluga approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@riccardofelluga riccardofelluga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's better to have it parametrized then to have two different tests with almost the same code. HF transformers library is nice and flexible

t-vi
t-vi approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @IvanYashchuk @riccardofelluga

@t-vi t-vi merged commit b21378c into main Nov 18, 2024
43 checks passed
@t-vi t-vi deleted the test-hf-phi3 branch November 18, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@riccardofelluga riccardofelluga riccardofelluga approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
dependencies huggingface For supporting HF models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanYashchuk @riccardofelluga @t-vi