-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add offset header ahead read for chunks #501
base: main
Are you sure you want to change the base?
add offset header ahead read for chunks #501
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
===================================
Coverage 79% 79%
===================================
Files 38 38
Lines 5659 5679 +20
===================================
+ Hits 4483 4502 +19
- Misses 1176 1177 +1 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adding the benchmark to the description of the PR ?
@bhimrazy So it doesn't seem very significant for larger dataset where more time is allocated to data transformation but it might be smaller ones with lower data transformation ? |
Maybe but I think it would be good to test on tiny imagenet too and also check the profiling. |
Before submitting
What does this PR do?
Add offset header ahead loading for chunks in PyTreeLoader
Some test metrics:
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃