-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Set default average='micro'
consistently across classification metrics (some of the subclasses of MulticlassStatScores
, MultilabelStatScores
)
#2882
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project check has failed because the head coverage (41%) is below the target coverage (95%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #2882 +/- ##
========================================
- Coverage 69% 41% -28%
========================================
Files 346 332 -14
Lines 19172 18996 -176
========================================
- Hits 13236 7742 -5494
- Misses 5936 11254 +5318 |
average='micro'
consistently across accuracy metricsaverage='micro'
consistently across classification metrics ( subclasses of MulticlassStatScores
, MultilabelStatScores
)
average='micro'
consistently across classification metrics ( subclasses of MulticlassStatScores
, MultilabelStatScores
)average='micro'
consistently across classification metrics (some of the subclasses of MulticlassStatScores
, MultilabelStatScores
)
45a06d4
to
b545a3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I undestand the mostivation and it sounds good at fist look, just for the context we tried to have the same default behavior as SK-learn so that is wy we do not have the same averaging everywhere... but open to chat about it and eventually make this breaking change...
cc: @lantiga @SkafteNicki
f6d659a
to
8b1ad0c
Compare
What does this PR do?
Partially Fixes #2320
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Changed the doctest values for subclasses of
MulticlassStatScores
,MultilabelStatScores
foraverage = 'micro'
as earlier default value wasaverage = 'macro'
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2882.org.readthedocs.build/en/2882/