chore: cleanup and docs batched Merkle tree & system program #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananas-block
force-pushed
the
jorrit/chore-handoff-batched-cleanup-5
branch
from
34e5e01 to
afbcf23
Compare
…y_proof.rs, replace ok_or() with ok_or_else()
ananas-block
force-pushed
the
jorrit/chore-handoff-batched-cleanup-5
branch
from
afbcf23 to
bd67a99
Compare
| @@ -760,8 +760,8 @@ async fn only_test_create_pda() { | |||
| assert_rpc_error( | |||
| result, | |||
| 0, | |||
| UtilsError::AccountNotMutable.into(), | |||
| // AccountCompressionErrorCode::AddressMerkleTreeAccountDiscriminatorMismatch.into(), | |||
| // UtilsError::AccountNotMutable.into(), | |||
There was a problem hiding this comment.
leftover - since it's tests we can merge regardless imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
.store_value()it wrapped a vector push which is unnecessary, ie replace for loop withsplit_at`MerkleTreeMetadatafrommerkle_tree.rstomerkle_tree_metadata.rsget_state_root_by_indexandget_address_root_by_indexfor integrating zkprograms which only need the root as proof input
leaf_index_could_exist_in_batches->check_leaf_index_could_exist_in_batchesderive_new_addressesrefactorinvoking_program_id_bytesfrom[u8;32]toOption<[u8;32]>verify_state_proof.rs->verify_proof.rsfetch_*->read_*(these functions read roots from Merkle tree accounts)