refactor: Use a regular Vec inside BoundedVec, add more tests
#680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
force-pushed
the
vadorovsky/bounded-vec-refactor-tests
branch
5 times, most recently
from
17cf033 to
32b89c1
Compare
ananas-block
reviewed
May 8, 2024
| pub struct BoundedVec<'a, T> | ||
| /// `Vec` is still used as the underlying data structure, `BoundedVec` exposes | ||
| /// only the methods which don't trigger reallocations. | ||
| pub struct BoundedVec<T>(Vec<T>) |
There was a problem hiding this comment.
Nice looks much cleaner and safer now!
The from raw parts makes it zero copy right?
There was a problem hiding this comment.
Yes, the from_raw_parts method from Vec should work the same way (just treat the given raw pointer as a store).
vadorovsky
force-pushed
the
vadorovsky/bounded-vec-refactor-tests
branch
5 times, most recently
from
8058300 to
5d0a685
Compare
* There is no need to use manual allocations in `BoundedVec`. Instead, we can just embed a regular `Vec`, make it private and make sure that the methods we expose never reallocate it. * Add more test cases covering all error variants.
vadorovsky
force-pushed
the
vadorovsky/bounded-vec-refactor-tests
branch
from
1726ccc to
f2f6963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BoundedVec. Instead, we can just embed a regularVec, make it private and make sure that the methods we expose never reallocate it.