Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: concurrent merkle tree, wrong upper_leaf in update_proof_from_changelog #684

Merged
merged 3 commits into from
May 9, 2024

Conversation

sergeytimoshin
Copy link
Contributor

No description provided.

Copy link
Contributor

@ananas-block ananas-block left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Can you add this change as well?

if self.changelog_capacity > 0 && changelog_index != self.changelog_index() {

It doesn't try to update the proof when the root is the same as onchain.

@ananas-block
Copy link
Contributor

weird that onchain tests are not triggered by rust library changes.
@sergeytimoshin can you enable program tests for changes on the merkle-tree/* folder as well?

@sergeytimoshin sergeytimoshin force-pushed the sergey/fix-mt-changelog-update branch 2 times, most recently from 00e7d16 to 8b80d3c Compare May 8, 2024 08:55
@sergeytimoshin sergeytimoshin force-pushed the sergey/fix-mt-changelog-update branch from 02b991a to 5a9eda7 Compare May 8, 2024 11:31
@sergeytimoshin sergeytimoshin force-pushed the sergey/fix-mt-changelog-update branch from 5a9eda7 to b85fa4d Compare May 8, 2024 15:17
@ananas-block ananas-block merged commit 78bbebc into main May 9, 2024
13 checks passed
@ananas-block ananas-block deleted the sergey/fix-mt-changelog-update branch May 9, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants