Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: token instruction creation & add onchain check #688

Merged
merged 2 commits into from
May 8, 2024

Conversation

ananas-block
Copy link
Contributor

@ananas-block ananas-block commented May 8, 2024

Issue:

  • if not all output Merkle tree indices are provided we didn't append all output compressed accounts to a state Merkle tree
  • there is a bug in the compressed token transfer instruction method that doesn't create enough output indices

Changes:

  • append_state.rs iterate over compressed output account instead of output indices to make sure that we insert every output account into a Merkle tree
  • fixed the bug in compressed token transfer instruction creation

@ananas-block ananas-block marked this pull request as ready for review May 8, 2024 14:24
@ananas-block ananas-block requested a review from vadorovsky as a code owner May 8, 2024 14:24
@vadorovsky vadorovsky merged commit 5e4cbeb into main May 8, 2024
13 checks passed
@vadorovsky vadorovsky deleted the jorrit/fix-token-instruction-creation branch May 8, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants