Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: nullifier queue failing tests full queue #700

Merged
merged 1 commit into from
May 13, 2024

Conversation

ananas-block
Copy link
Contributor

@ananas-block ananas-block commented May 10, 2024

Changes:

  • add failing test for nullifier queue operations to show that we cannot insert into a full queue.
    Scenario:
  1. try to insert into queue to generate the full error
  2. nullify one
  3. try to insert again it should still generate the full error
  4. advance Merkle tree seq until one before it would work check that it still fails
  5. advance Merkle tree seq by one and check that inserting works now
    6.try inserting again it should fail with full error

@ananas-block ananas-block requested a review from vadorovsky as a code owner May 10, 2024 19:12
@ananas-block ananas-block marked this pull request as draft May 10, 2024 19:12
@ananas-block ananas-block force-pushed the jorrit/test-nullifier-queue-functional branch 2 times, most recently from 70744ad to 4bff2bf Compare May 10, 2024 21:09
@ananas-block ananas-block marked this pull request as ready for review May 10, 2024 21:11
@ananas-block ananas-block force-pushed the jorrit/test-nullifier-queue-functional branch from 4bff2bf to be6c0c4 Compare May 10, 2024 21:14
@ananas-block ananas-block changed the title test: nullifier queue functional test: nullifier queue failing tests full queue May 10, 2024
@ananas-block ananas-block force-pushed the jorrit/test-nullifier-queue-functional branch 2 times, most recently from e784bb8 to 47490b7 Compare May 13, 2024 13:16
@ananas-block ananas-block force-pushed the jorrit/test-nullifier-queue-functional branch from 47490b7 to 3a6ee9b Compare May 13, 2024 14:07
@SwenSchaeferjohann SwenSchaeferjohann merged commit 006e9af into main May 13, 2024
13 checks passed
@SwenSchaeferjohann SwenSchaeferjohann deleted the jorrit/test-nullifier-queue-functional branch May 13, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants