Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to pass custom photon db url to cli/test-validator #702

Merged
merged 3 commits into from
May 11, 2024

Conversation

sergeytimoshin
Copy link
Contributor

No description provided.

@SwenSchaeferjohann
Copy link
Contributor

needs rebase otherwise lgtm! @sergeytimoshin

Added a feature to pass a custom database URL for the indexer.
@sergeytimoshin sergeytimoshin force-pushed the sergey/cli-custom-photon-db branch from f5dfb52 to a890648 Compare May 11, 2024 21:01
@SwenSchaeferjohann
Copy link
Contributor

SwenSchaeferjohann commented May 11, 2024

curious if there's a simple way to test the use of a custom db properly in ci?

@SwenSchaeferjohann SwenSchaeferjohann merged commit b1932ff into main May 11, 2024
6 checks passed
@SwenSchaeferjohann SwenSchaeferjohann deleted the sergey/cli-custom-photon-db branch May 11, 2024 21:47
@sergeytimoshin
Copy link
Contributor Author

curious if there's a simple way to test the use of a custom db properly in ci?

We don't have test-validator test setup yet, so the first logical step would be to create validator cmd test.
As regards to custom db tests, I'm using psql docker env for my local tests, so we can just reuse that: run light test-validator => then pg_isready -- <db-url>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants