test: Add unit tests for light_utils::offset
#832
Conversation
vadorovsky
force-pushed
the
vadorovsky/test-offset-util
branch
2 times, most recently
from
9453939 to
33a850c
Compare
vadorovsky
force-pushed
the
vadorovsky/test-offset-util
branch
from
dcc5224 to
fe8c5da
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 658fa72. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
utils/src/offset/copy.rs
Outdated
| let size = mem::size_of::<T>(); | ||
| let ptr = bytes[*offset..*offset + size].as_ptr() as *const T; | ||
| *offset += size; | ||
| // (*ptr).clone() |
| where | ||
| T: Clone, | ||
| { | ||
| let size = mem::size_of::<T>() * metadata.capacity(); |
There was a problem hiding this comment.
We could add a safety comment that you cannot use this if T has properties that are vectors.
There was a problem hiding this comment.
Done, included it in the docstring
utils/src/offset/copy.rs
Outdated
| (*s).a = -9223372036854771632; | ||
| (*s).b = 9223372036854771632; | ||
| (*s).c = -9223372036854771632; | ||
| (*s).d = 9223372036854771632; |
There was a problem hiding this comment.
could we use i64::MAX / u64::MAX?
| #[repr(C)] | ||
| struct TestStruct { | ||
| a: [i64; 32], | ||
| b: [u64; 32], |
There was a problem hiding this comment.
probably makes sense to do an explicit test with [u8;32] as well since that is what we use in prod in most cases.
vadorovsky
force-pushed
the
vadorovsky/test-offset-util
branch
2 times, most recently
from
658fa72 to
3d49075
Compare
utils/src/offset/zero_copy.rs
Outdated
| (*s).g = -32721; | ||
| (*s).h = 32721; | ||
| (*s).i = -127; | ||
| (*s).j = 127; |
There was a problem hiding this comment.
More magic numbers, other wise looks good feel free to merge after rebase and fix :)
* Reorganize the code to make clear distinction between zero-copy and copy utilities. * Cover the whole module with tests.
The former works fine with uninitialized regions. The latter does not.
* Use `MIN` and `MAX` values of primitive types. * Read vectors with `[u8; 32]` as a type.
vadorovsky
force-pushed
the
vadorovsky/test-offset-util
branch
from
8d5141c to
4719758
Compare
copy utilities.