Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prover is less with test #841

Merged
merged 3 commits into from
Jun 23, 2024
Merged

fix: prover is less with test #841

merged 3 commits into from
Jun 23, 2024

Conversation

ananas-block
Copy link
Contributor

@ananas-block ananas-block commented Jun 19, 2024 •
edited
Loading

Issues:

  • isLess gnark api uses api.ToBinary which is broken for fully width decomposition see Issue

Changes:

  • reimplement IsLess with limited binary decomposition
  • test for IsLess
  • unit test start description in readme
  • inlcusion and non-inclusion failing tests:
    • test with invalid pathIndex +1 and - 1
  • Renaming:
    • ProofRound -> ProveParentHash
    • Direction -> Bit
    • sum -> hash

@ananas-block ananas-block marked this pull request as ready for review June 20, 2024 20:37
@ananas-block ananas-block requested a review from vadorovsky as a code owner June 20, 2024 20:37
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 20, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9bb32c4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx test @lightprotocol/stateless.js

Sent with 💌 from NxCloud.

@ananas-block ananas-block force-pushed the jorrit/fix-gnark-non-inclusion-is-less branch from 39a7b03 to 3cda9a8 Compare June 20, 2024 21:07
@ananas-block
fix: is less
b28be3e 
tests: add test cases, readme add test instructions

disable nx cache in nx json

Disable nx cloud cache
@ananas-block ananas-block force-pushed the jorrit/fix-gnark-non-inclusion-is-less branch from b48697e to b28be3e Compare June 21, 2024 17:29
@ananas-block ananas-block mentioned this pull request Jun 22, 2024
Merged
sergeytimoshin
sergeytimoshin requested changes Jun 22, 2024
View reviewed changes
cli/package.json Outdated Show resolved Hide resolved
cli/package.json Outdated Show resolved Hide resolved
cli/package.json Outdated Show resolved Hide resolved
cli/package.json Outdated Show resolved Hide resolved
circuit-lib/circuit-lib.js/package.json Outdated Show resolved Hide resolved
@sergeytimoshin sergeytimoshin merged commit bd4b7de into main Jun 23, 2024
8 checks passed
@sergeytimoshin sergeytimoshin deleted the jorrit/fix-gnark-non-inclusion-is-less branch June 23, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeytimoshin sergeytimoshin sergeytimoshin approved these changes

@vadorovsky vadorovsky Awaiting requested review from vadorovsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ananas-block @sergeytimoshin