test: Add more tests for light_utils main module
#846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
force-pushed
the
vadorovsky/test-light-utils-lib
branch
from
0cf0ec3 to
776f078
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 776f078. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
vadorovsky
force-pushed
the
vadorovsky/test-light-utils-lib
branch
from
776f078 to
f03082b
Compare
Achieve full coverage there.
vadorovsky
force-pushed
the
vadorovsky/test-light-utils-lib
branch
from
f03082b to
b94e701
Compare
utils/src/lib.rs
Outdated
| let max_input = [u8::MAX; 32]; | ||
| let (hashed_value, bump) = hash_to_bn254_field_size_be(max_input.as_slice()) | ||
| .expect("Failed to find a hash within BN254 field size"); | ||
| assert_eq!(bump, 255, "Bump seed should be 0"); |
There was a problem hiding this comment.
The assert error msg confused me, shouldn't it read as follows?
Suggested change
| assert_eq!(bump, 255, "Bump seed should be 0"); | |
| assert_eq!(bump, 255, "Bump seed should be 255"); |
| let bigint = modulus + 1.to_biguint().unwrap(); | ||
| let bigint_bytes: [u8; 32] = bigint_to_be_bytes_array(&bigint).unwrap(); | ||
| assert!(!is_smaller_than_bn254_field_size_be(&bigint_bytes)); | ||
| } |
ananas-block
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Achieve full coverage there.