chore: prover rename leaf index next index #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananas-block
force-pushed
the
jorrit/chore-prover-rename-leaf-index-next-index
branch
2 times, most recently
from
415349c to
4b046e0
Compare
ananas-block
force-pushed
the
jorrit/chore-prover-rename-leaf-index-next-index
branch
from
4b046e0 to
982aa9c
Compare
ananas-block
force-pushed
the
jorrit/chore-prover-rename-leaf-index-next-index
branch
from
4897f1f to
744e511
Compare
ananas-block
force-pushed
the
jorrit/chore-prover-rename-leaf-index-next-index
branch
from
744e511 to
0c7f6f5
Compare
The commit updates variables and parameters names in the light-prover, changing from camelCase to snake_case for better readability and consistency. This includes updates in the scripts `generate_keys.sh` and `main.go`. Changes have been made in flags like `compressedAccounts` to `compressed-accounts` and array names like `compressedAccounts_arr` to `compressed_accounts_arr`.
vadorovsky
approved these changes
Jun 25, 2024
| pub const FIELD_SIZE_SUB_ONE: &str = | ||
| "21888242871839275222246405745257275088548364400416034343698204186575808495616"; | ||
| pub const HIGHEST_ADDRESS_PLUS_ONE: &str = | ||
| "452312848583266388373324160190187140051835877600158453279131187530910662655"; |
There was a problem hiding this comment.
What does this value stand for now? It seems lower than the Fr field size limit. Is it intentional to reduce the available range of addresses?
There was a problem hiding this comment.
- isLess limits the bitsize to 248 bit equivalent to truncated addresses of 31 bytes
- our highest indexed array value FIELD_SIZE - 1 is too great now to work with the circuit,
HIGHEST_ADDRESS_PLUS_ONEis2^248 -1the highest 248 bit value. The highest address must be less thanHIGHEST_ADDRESS_PLUS_ONEhence the name plus one.
- our highest indexed array value FIELD_SIZE - 1 is too great now to work with the circuit,
sergeytimoshin
approved these changes
Jun 25, 2024
ananas-block
deleted the
jorrit/chore-prover-rename-leaf-index-next-index
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds on #850
changes:
test_tree.go->merkle_tree.gotree_test.go->gen_test_data.goHIGHEST_ADDRESS_PLUS_ONEis2^248 -1the highest 248 bit value. The highest address must be less thanHIGHEST_ADDRESS_PLUS_ONEhence the name plus one.