1주차 Assignment - 강두오 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rommmu
approved these changes
Mar 29, 2024
| public class Main { | ||
| public static void main(String[] args) throws IOException { | ||
| BufferedReader br = new BufferedReader(new InputStreamReader(System.in)); | ||
| StringBuilder sb = new StringBuilder(); |
There was a problem hiding this comment.
피드백
이렇게 StringBuilder를 사용하여 append 하신 게 평소 알고리즘에서 메모리에 대해 신경을 많이 쓰고 계신 것 같아 멋집니다 😎
Comment on lines
+17
to
+22
| if (m < 45) { | ||
| h = (h + 23) % 24; | ||
| m += 15; | ||
| } | ||
| else | ||
| m -= 45; |
There was a problem hiding this comment.
피드백
저는 중첩 if로 입력된 시간에 따라 나눌 생각을 하였는데, 이렇게 풀이한 걸 보고 놀랐습니당! 새로운 사고 방식 배워갑니다
Comment on lines
34
to
37
| // volume 메서드: 면적과 높이를 이용하여 부피를 반환 | ||
| public double volume() { | ||
| return area() * height; | ||
| } |
There was a problem hiding this comment.
피드백
알고리즘이나 코드 상 문제가 없으나,
public double volume() { return this.area() * height; }
처럼 this 키워드를 추가해주는 것이 현재 객체의 area 메서드임을 명시하여 것으로 가독성 측면에서 조금 더 좋을 수 있다는 생각을 합니다!
There was a problem hiding this comment.
앗.. 그렇네요!
전체적으로 상세한 피드백 남겨주셔서 감사드립니다 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<!— 구현 및 작업 내용을 적어주세요 —>
Important content
<!— 주의 깊게 봐줬으면 하는 부분을 적어주세요 —>
Question
<!— 궁금한 점을 적어주세요 —>
Reference
<!— 참고한 레퍼런스가 있다면 공유해 주세요 —>