1주차 Assignment - 이서영 #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rommmu
reviewed
Apr 1, 2024
| @@ -0,0 +1,19 @@ | |||
| import java.util.Scanner; | |||
| package bj_11201 | |||
| name[i] = str.substring(0,1)+ str.substring(str.length()-1,str.length()); | ||
| } | ||
|
|
||
| sc.close(); |
There was a problem hiding this comment.
피드백
Scanner close 같은 경우는 맨 마지막에 작성하는게 좋습니다
Comment on lines
4
to
6
| public double PI = 3.14; int centerX; | ||
| int centerY;// | ||
| double R;// |
There was a problem hiding this comment.
가이드라인 미준수
주석 코드와 다릅니다.
그리고 변수는 소문자 그리고 카멜케이스로 표기하는 것이 좋습니다.
Comment on lines
8
to
12
| public Cylinder(int x, int y, double r) { | ||
| centerX = x; | ||
| centerY = y; | ||
| R = r; // 생성자1: 정수 인자 x, y 와 실수 인자 r을 전달 받아서 해당 필드 값을 초기화 | ||
| } |
Comment on lines
14
to
19
| public Cylinder(int x, int y, int height, double r) { | ||
| centerX = x; | ||
| centerY = y; | ||
| this.height = height; | ||
| R = r; // 생성자2: 정수 인자 x, y, height 와 실수 인자 r을 전달 받아서 해당 필드 값을 초기화 | ||
| } |
There was a problem hiding this comment.
가이드라인 미준수
마찬가지로 해당 필드 값을 초기화하는 생성자가 아닙니다.
Rommmu
approved these changes
Apr 1, 2024
Rommmu
added
✅ 과제 통과
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<!— 구현 및 작업 내용을 적어주세요 —>
Important content
<!— 주의 깊게 봐줬으면 하는 부분을 적어주세요 —>
Question
<!— 궁금한 점을 적어주세요 —>
Reference
<!— 참고한 레퍼런스가 있다면 공유해 주세요 —>