12주차 Assignment - 양라윤 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khj0426
reviewed
Sep 23, 2024
| setDebouncedValue(value); | ||
| }, delay); | ||
|
|
||
| return () => { |
| tab: "music is 마랖...", | ||
| content: "🎶🎵🎶🎶🎶🎵🎵", | ||
| }, | ||
| { |
| ]; | ||
|
|
||
| function App() { | ||
| const { currentItem, changeItem } = useTabs(0, content); |
There was a problem hiding this comment.
요렇게 숫자를 바로 집어넣는 것보단 숫자를 상수화해서 상수로 사용하는 법도 있는데요!
요 글 읽어보세욤!
| const { currentItem, changeItem } = useTabs(0, content); | ||
| const fadeInContent = useFadeIn(1, 2); | ||
|
|
||
| const [query, setQuery] = useState(""); |
There was a problem hiding this comment.
보통 컴포넌트는 UI를 그린다<-요 역할만 하도록 최대한 역할과 책임을 분리하는 게 좋아요!
그래서 복잡한 로직이나 계산들을 커스텀 훅으로 뺴곤 한답니당..!
만약 이 친구들을 ㅌ커스텀훅으로 뺀다면 어떻게 만들 수 있을까용
| <div> | ||
| <h1>취미 소개 페이지</h1> | ||
| <Search | ||
| type="text" |
| /> | ||
| <p>{apiResult}</p> | ||
| {content.map((section, index) => ( | ||
| <BtnSt onClick={() => changeItem(index)}>{section.tab}</BtnSt> |
| `; | ||
|
|
||
| export const StyledCalendar = styled(Calendar)` | ||
| width: 100%; |
There was a problem hiding this comment.
react calendar와 엮인 클래스 이름을 요기서 선언하기 보단 따로 CSS파일을 만드는 게 더 좋을 것 같아요
| @@ -0,0 +1,19 @@ | |||
| import { useState, useEffect } from "react"; | |||
|
|
|||
| function useDebounce(value, delay) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Important content
Question