13주차 Assignment - 조성수 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayoon07
approved these changes
Oct 6, 2024
Comment on lines
+18
to
+34
| const letterVariants = { | ||
| hidden: { opacity: 0, scale: 0.5 }, | ||
| visible: { | ||
| opacity: 1, | ||
| scale: 1.3, | ||
| transition: { duration: 0.8 }, // 글자당 최소 0.5초 이상 지속 | ||
| }, | ||
| }; | ||
|
|
||
| const containerVariants = { | ||
| hidden: {}, | ||
| visible: { | ||
| transition: { | ||
| staggerChildren: 0.15, // 0.15초 간격으로 등장 | ||
| }, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
variant 사용도 잘 해주셨고 세부 조건도 잘 충족시켜주셨네요! 💯
조성수/animation/src/main.jsx
Outdated
There was a problem hiding this comment.
다만 logo 외에 다른 기능은 없기 때문에 main보다는 파일명이 좀 더 직관적이면 좋겠습니다!
Comment on lines
+25
to
+29
| const Image = styled.img` | ||
| width: 100%; | ||
| height: 400px; | ||
| object-fit: cover; | ||
| `; |
There was a problem hiding this comment.
동물 사진의 높이를 설정해두어서 사진들이 다 잘립니다 ㅜㅜ
비율을 맞춰주시거나 사진이 좀 커지더라도 width와 같이 100%으로 하는 게 더 좋을 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Important content
Question
Reference