멋사 3차 과제 - 이예린 #10
Open
멋사 3차 과제 - 이예린 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayujin-dev
requested changes
May 9, 2023
assignment/3th_index.html
Outdated
| <div class="title-box"> | ||
| <h1>Yerin Lee</h1> | ||
| </div> | ||
| <div class="card" style="width: 18rem;"> |
There was a problem hiding this comment.
여기서부터 쓴 card 부트스트랩은 수업때 한 내용인것같네요! 커밋 메세지와 수정된 코드 내용이 일치하게끔 작성하시면 코드리뷰가 더 도움이 될것같아요.
| <h1>Yerin Lee</h1> | ||
| </div> | ||
| <section> | ||
| <div class="card" style="width: 35rem;"> |
There was a problem hiding this comment.
같은 내용이 이전 커밋에도 있는것 같습니다.
혹시 다른 내용인데 제가 놓친거라면 말씀해주세요!
아니면 같은 내용을 다시 커밋한 이유가 따로 있는걸까요?
커밋 메시지를 더 구체적으로 작성하거나, 혹은 PR을 날릴때 본문에 그에대해 언급해주시면 더 원활한 코드리뷰가 가능해요.
| @@ -0,0 +1,44 @@ | |||
| @import url('https://fonts.googleapis.com/css2?family=IBM+Plex+Sans+KR:wght@300;400;600&display=swap'); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
closed #9
✨ 과제 내용
📸 스크린샷(선택)
📚 레퍼런스 (또는 새로 알게 된 내용) 혹은 궁금한 사항들