Skip to content
This repository has been archived by the owner on Dec 8, 2024. It is now read-only.

feat: starter database design and functionality #15

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

MitchellJC
Copy link
Collaborator

  • Basic schema definition which is used to initialise database in init_database function.
  • Notebook for examples of database function use.

Copy link
Owner

@LimaoC LimaoC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. 1 question, if the user leaves the view of the camera, will this be the end of a period? So we can have a function to check that the user's in frame and the camera's aligned before counting it as a posture period.

@MitchellJC
Copy link
Collaborator Author

lgtm. 1 question, if the user leaves the view of the camera, will this be the end of a period? So we can have a function to check that the user's in frame and the camera's aligned before counting it as a posture period.

Yeah thats how I was picturing it. Probably handled by the posture tracker which would be continously checking if the current period is valid. If it suddenly becomes invalid it could stop the period there and commit a change to the DB.

@LimaoC
Copy link
Owner

LimaoC commented Aug 15, 2024

lgtm. 1 question, if the user leaves the view of the camera, will this be the end of a period? So we can have a function to check that the user's in frame and the camera's aligned before counting it as a posture period.

Yeah thats how I was picturing it. Probably handled by the posture tracker which would be continously checking if the current period is valid. If it suddenly becomes invalid it could stop the period there and commit a change to the DB.

Yep sounds good to me

@MitchellJC MitchellJC force-pushed the mitch-database-design branch from 002bbbe to e0b3461 Compare August 16, 2024 00:45
@MitchellJC MitchellJC merged commit e43680e into main Aug 16, 2024
2 checks passed
@MitchellJC MitchellJC deleted the mitch-database-design branch August 16, 2024 00:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants