Skip to content
This repository was archived by the owner on Dec 8, 2024. It is now read-only.

doc: added attribute docs to existing code #29

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

MitchellJC
Copy link
Collaborator

No description provided.

@MitchellJC MitchellJC requested a review from LimaoC August 19, 2024 06:35
@MitchellJC MitchellJC self-assigned this Aug 19, 2024
@LimaoC
Copy link
Owner

LimaoC commented Aug 19, 2024

Hmm the dummy descriptions are still being generated on my end, do you get the same thing?

image
image

@MitchellJC
Copy link
Collaborator Author

Hmm the dummy descriptions are still being generated on my end, do you get the same thing?

Ah okay yeah I am. Looking at that post from your other PR it actually looks like they had the issue we are having now where they had their own docs and it was being duplicated, so I think we still just apply your fix and it should keep these docs we've added?

@LimaoC
Copy link
Owner

LimaoC commented Aug 19, 2024

Hmm the dummy descriptions are still being generated on my end, do you get the same thing?

Ah okay yeah I am. Looking at that post from your other PR it actually looks like they had the issue we are having now where they had their own docs and it was being duplicated, so I think we still just apply your fix and it should keep these docs we've added?

Yeah that sounds good. That fix doesn't work for class attributes however, but I've also got a fix for that so we should be fine.

Copy link
Owner

@LimaoC LimaoC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should be good after the changes in #28

@MitchellJC MitchellJC merged commit 7aa3853 into main Aug 19, 2024
2 checks passed
@MitchellJC MitchellJC deleted the mitch-doc-attr branch August 19, 2024 07:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants