This repository has been archived by the owner on Dec 8, 2024. It is now read-only.
Implemented login system driver #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format changes from running black on file
so that debugging is easier on rpi
avg-lebesgue-enjoyer
suggested changes
Oct 6, 2024
client/drivers/data_structures.py
Outdated
| Make a valid Picture. | ||
| Args: | ||
| message: Message to send to the user | ||
| message_time: Time to sleep for after displaying message. |
There was a problem hiding this comment.
Should clarify that this is in units of SECONDS (other code is in units of milliseconds)
| return_me.matched = True | ||
| return_me.user_id = user_id | ||
| return return_me | ||
| def _clear_buttons(self) -> None: |
There was a problem hiding this comment.
docstring pls
client/drivers/main.py
Outdated
| @@ -575,6 +398,7 @@ def handle_sniff_feedback(auspost: ControlledData) -> bool: | |||
|
|
|||
|
|
|||
| ## LAUNCH | |||
| hardware = initialise_hardware() | |||
There was a problem hiding this comment.
This should be inside the if __name__ == "__main__": guard, or buried somewhere within.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes in
data_structuresare from black formatting on save. There are two new methods for a simpler message display and waiting for a button press at the bottom ofHardwareComponents.PictureandFaceclass have been deleted as they are no longer used anywhere.