fix: Separated justification verification for preVotes from preCommits. #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zurcusa
reviewed
Feb 24, 2025
| (preVotes, preCommits) -> preVotes && preCommits); | ||
|
|
||
| try { | ||
| boolean verified = verifiedFuture.get(); |
There was a problem hiding this comment.
Suggested change
| boolean verified = verifiedFuture.get(); | |
| boolean verified = verifiedFuture.join(); |
You can use join() to avoid the try catch here.
Zurcusa
approved these changes
Feb 24, 2025
Grigorov-Georgi
approved these changes
Feb 24, 2025
added 2 commits
February 24, 2025 13:10
JustificationVerificationException.java
|
hMitov
deleted the
797-Separate-preVotes-and-preCommits-justifications-in-catch-up-response
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separated justification verification for preVotes and preCommits. Previously, they were verified together as part of a single list.
Now, we create two distinct justifications—one for preVotes and another for preCommits.