Add animationType to BatchUpdates #177
Conversation
… / deleteRows / reloadRows / insertSections / deleteSections / reloadSections
|
Hi ! Still no news since january 4th for my PR, maybe I missed something or I have to ask for a review ? Regards, |
| @@ -120,27 +120,27 @@ extension UITableView: ReloadableView { | |||
|
|
|||
| // Update items. | |||
| if batchUpdates.insertItems.count > 0 { | |||
| insertRows(at: batchUpdates.insertItems, with: .automatic) | |||
| insertRows(at: batchUpdates.insertItems, with: batchUpdates.animationType) | |||
There was a problem hiding this comment.
Can we control the animations on the collection view in a similar way? See line 70 in this file.
There was a problem hiding this comment.
Unfortunately, in UIKit collection view doesn't have the same animation properties, you can only insert / delete / reload / move without any more possibility. :( That's why I only updated table view animations
There was a problem hiding this comment.
More than 2 months since my last answer... Could you please at least read it ?
|
Apologies for the delay, @fmirault . I added a comment. This adapter is used for both table views and collection views, so it'd be odd to have a property that has no effect in some cases. Would it be possible to make it (or something like it) work in both cases? |
|
Collection View isn't working like Table View, so I don't really see how I can achieve the same effect on it (it's an UIKit limitation in my opinion). |
and use it for insertRows / deleteRows / reloadRows / insertSections / deleteSections / reloadSections methods.
Possible addition to #124 for animations.