This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
Fix bug where a parent LK node purges child LK node's subviews #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem:
If you have a LayoutKit root node ("A") and somewhere in its subview hierarchy is another LayoutKit root node ("B"), and you call makeViews from A then it will traverse its entire subview hierarchy, including B's hierarchy, and remove views from B's hierarchy in ViewRecycler:purgeViews at:
All other forms of layout allow for alternative layout strategies to be used freely at different places in the hierarchy without being intrusive like this. LayoutKit should resolve this internally.