This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
Remove UIView.init() is called in outside of the main thread #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getogrand
force-pushed
the
fix-main-thread-error
branch
2 times, most recently
from
41c88e2
to
5f4d4cf
Compare
getogrand
force-pushed
the
fix-main-thread-error
branch
from
5f4d4cf
to
7c2a7ff
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In class
LabelLayoutDefaults,UILabel.init()is called on static stored property declaration.This leads
[UIView init] must be used from main thread onlywarning on Xcode.Moreover, it breaks on runtime some cases (e.g. XCUITest tests layout built with using LabelLayout)
This PR fixes this problem.