Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Authentication works in 0.4.0, but not in 0.4.1 - AQUIRE_ROOT_VIEW_CONTROLLER_FAILED #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Will5
Copy link

@Will5 Will5 commented Nov 17, 2022

As per discussion in 135, I created a pull request. I tested in a Flutter application, but not in an "add to app" use case.

@ThexXTURBOXx
Copy link
Contributor

ThexXTURBOXx commented Dec 13, 2022

@Will5 I have pushed your changes into a separate branch in flutter_web_auth_2.
It would be very nice if you could test them on your device(s) to see if they fix your issue: https://github.com/ThexXTURBOXx/flutter_web_auth_2/tree/fix-135
You can use the branch by using the following entry in your pubspec.yaml:

  flutter_web_auth_2:
    git:
      url: https://github.com/ThexXTURBOXx/flutter_web_auth_2.git
      ref: fix-135

@ThexXTURBOXx
Copy link
Contributor

@Will5 Sorry for pinging you again, I just wanted to ask you if you had a chance to try my branch out. Then, I could publish the fix for everyone to profit :)

@Will5
Copy link
Author

Will5 commented Dec 30, 2022

@ThexXTURBOXx, odd. When I use your branch, I get the AQUIRE_ROOT_VIEW_CONTROLLER_FAILED error, but when I use my branch, I don't. I'm trying to figure out what's different.

flutter_web_auth_2:
  git:
    url: https://github.com/ThexXTURBOXx/flutter_web_auth_2.git
    ref: fix-135
    path: flutter_web_auth_2
flutter_web_auth:
  git:
    url: https://github.com/Will5/flutter_web_auth.git
    ref: AQUIRE_ROOT_VIEW_CONTROLLER_FAILED

EDIT: @ThexXTURBOXx, never mind. I was also able to get it to work, but there appears to be some sort of race condition. I went back to your branch, and if I clicked on the button quickly, I got the error, but if I waited a little bit and clicked on the button, I didn't. I'll see if I can figure that out what could be causing it.

@ThexXTURBOXx
Copy link
Contributor

@Will5 Thanks for reporting back! Okay, let me know when you find a solution and I will merge it asap :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants