🎉 Add overwrite option

This closes #130
LinusU · Oct 29, 2017 · a98ef5f · a98ef5f
1 parent deb0ee7
commit a98ef5f
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 20 deletions.
diff --git a/README.md b/README.md
@@ -53,6 +53,7 @@ the JSON file's path.
 + `background` (string, optional) - Path to your background
 + `background-color` (string, optional) - Background color (accepts css colors)
 + `icon-size` (number, optional) - Size of all the icons inside the DMG
++ `overwrite-target` (boolean, optional) - Overwrite target if it exists
 + `window` (object, optional) - Window options
     + `position` (object, optional) - Position when opened
         + `x` (number, required) - X position relative to left of the screen

diff --git a/lib/appdmg.js b/lib/appdmg.js
@@ -72,26 +72,6 @@ module.exports = exports = function (options) {
 
   var pipeline = new Pipeline()
 
-  /**
-   **
-   **/
-
-  pipeline.addStep('Looking for target', function (next) {
-    fs.writeFile(global.target, '', { flag: 'wx' }, function (err) {
-      if (err && err.code === 'EEXIST') return next(new Error('Target already exists'))
-      if (err) return next(err)
-
-      pipeline.addCleanupStep('unlink-target', 'Removing target image', function (next, hasErrored) {
-        if (hasErrored) {
-          fs.unlink(global.target, next)
-        } else {
-          next(null)
-        }
-      })
-      next(null)
-    })
-  })
-
   /**
    **
    **/
@@ -148,6 +128,26 @@ module.exports = exports = function (options) {
     next(new Error(message))
   })
 
+  /**
+   **
+   **/
+
+  pipeline.addStep('Looking for target', function (next) {
+    fs.writeFile(global.target, '', { flag: global.opts['overwrite-target'] ? 'w' : 'wx' }, function (err) {
+      if (err && err.code === 'EEXIST') return next(new Error('Target already exists'))
+      if (err) return next(err)
+
+      pipeline.addCleanupStep('unlink-target', 'Removing target image', function (next, hasErrored) {
+        if (hasErrored) {
+          fs.unlink(global.target, next)
+        } else {
+          next(null)
+        }
+      })
+      next(null)
+    })
+  })
+
   /**
    **
    **/

diff --git a/schema.json b/schema.json
@@ -19,6 +19,9 @@
     "icon-size": {
       "type": "integer"
     },
+    "overwrite-target": {
+      "type": "boolean"
+    },
     "window": {
       "type": "object",
       "properties": {