Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make aws access key optional #11

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Make aws access key optional #11

merged 2 commits into from
Jul 17, 2024

Conversation

ishantiw
Copy link
Member

What was the problem?

This PR resolves #10

How was it solved?

  • Make accessKeyId and secretAccessKey as optional

How was it tested?

Run config without it with the appropriate key access on AWS

@ishantiw ishantiw requested a review from shuse2 July 16, 2024 16:03
@ishantiw ishantiw self-assigned this Jul 16, 2024
@ishantiw ishantiw changed the title ♻️ Make aws access key optional Make aws access key optional Jul 16, 2024
shuse2
shuse2 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good, but original code doesn't work by just changing to below?

accessKeyId?: string;
secretAccessKey?: string;

@ishantiw ishantiw merged commit a584a4c into master Jul 17, 2024
1 check passed
@ishantiw ishantiw deleted the 10-acesskey-optional branch July 17, 2024 08:06
ishantiw added a commit that referenced this pull request Jul 17, 2024
@ishantiw
Make aws access key optional (#11)
1c909f3 
### What was the problem?

This PR resolves #10 

### How was it solved?

- Make `accessKeyId` and `secretAccessKey` as optional

### How was it tested?

Run config without it with the appropriate key access on AWS
ishantiw added a commit that referenced this pull request Jul 17, 2024
@ishantiw
Make aws access key optional (#11)
c63588b 
### What was the problem?

This PR resolves #10 

### How was it solved?

- Make `accessKeyId` and `secretAccessKey` as optional

### How was it tested?

Run config without it with the appropriate key access on AWS
ishantiw added a commit that referenced this pull request Aug 7, 2024
@ishantiw
Make aws access key optional (#11)
9d1860d 
### What was the problem?

This PR resolves #10 

### How was it solved?

- Make `accessKeyId` and `secretAccessKey` as optional

### How was it tested?

Run config without it with the appropriate key access on AWS
ishantiw added a commit that referenced this pull request Aug 7, 2024
@ishantiw
Make aws access key optional (#11)
f894d4b 
### What was the problem?

This PR resolves #10 

### How was it solved?

- Make `accessKeyId` and `secretAccessKey` as optional

### How was it tested?

Run config without it with the appropriate key access on AWS
sameersubudhi pushed a commit that referenced this pull request Sep 6, 2024
@ishantiw @sameersubudhi
Make aws access key optional (#11)
39ede4f 
### What was the problem?

This PR resolves #10 

### How was it solved?

- Make `accessKeyId` and `secretAccessKey` as optional

### How was it tested?

Run config without it with the appropriate key access on AWS
sameersubudhi pushed a commit that referenced this pull request Sep 10, 2024
@ishantiw @sameersubudhi
Make aws access key optional (#11)
a20e54c 
### What was the problem?

This PR resolves #10 

### How was it solved?

- Make `accessKeyId` and `secretAccessKey` as optional

### How was it tested?

Run config without it with the appropriate key access on AWS
sameersubudhi pushed a commit that referenced this pull request Sep 10, 2024
@ishantiw @sameersubudhi
Make aws access key optional (#11)
b8f083d 
### What was the problem?

This PR resolves #10 

### How was it solved?

- Make `accessKeyId` and `secretAccessKey` as optional

### How was it tested?

Run config without it with the appropriate key access on AWS
sameersubudhi pushed a commit that referenced this pull request Sep 10, 2024
@ishantiw @sameersubudhi
Make aws access key optional (#11)
39b2ba4 
### What was the problem?

This PR resolves #10 

### How was it solved?

- Make `accessKeyId` and `secretAccessKey` as optional

### How was it tested?

Run config without it with the appropriate key access on AWS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuse2 shuse2 shuse2 approved these changes

Assignees

@ishantiw ishantiw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make aws access key as optional
2 participants
@ishantiw @shuse2