Improve installation script for code deploy #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matjazv
force-pushed
the
LISK-912-improve-installation-script-for-code-deploy
branch
from
ae221a8 to
fd64dff
Compare
matjazv
force-pushed
the
LISK-912-improve-installation-script-for-code-deploy
branch
from
fd64dff to
a022cfa
Compare
sameersubudhi
approved these changes
Aug 14, 2024
ishantiw
requested changes
Aug 14, 2024
matjazv
force-pushed
the
LISK-912-improve-installation-script-for-code-deploy
branch
from
3d022a4 to
df81640
Compare
ishantiw
deleted the
LISK-912-improve-installation-script-for-code-deploy
branch
sameersubudhi
pushed a commit
that referenced
this pull request
Sep 6, 2024
### What was the problem? This PR resolves LISK-912. ### How was it solved? - [x] Execute `installDependencies.sh` script inside `AfterInstall` hook. - [x] Execute scripts inside `appspec.yml` as root. - [x] Use `--frozen-lockfile` for `yarn install` - [x] Read and use node version from `.nvmrc` file ### How was it tested? `installDependencies.sh` script was locally executed
sameersubudhi
pushed a commit
that referenced
this pull request
Sep 10, 2024
### What was the problem? This PR resolves LISK-912. ### How was it solved? - [x] Execute `installDependencies.sh` script inside `AfterInstall` hook. - [x] Execute scripts inside `appspec.yml` as root. - [x] Use `--frozen-lockfile` for `yarn install` - [x] Read and use node version from `.nvmrc` file ### How was it tested? `installDependencies.sh` script was locally executed
sameersubudhi
pushed a commit
that referenced
this pull request
Sep 10, 2024
### What was the problem? This PR resolves LISK-912. ### How was it solved? - [x] Execute `installDependencies.sh` script inside `AfterInstall` hook. - [x] Execute scripts inside `appspec.yml` as root. - [x] Use `--frozen-lockfile` for `yarn install` - [x] Read and use node version from `.nvmrc` file ### How was it tested? `installDependencies.sh` script was locally executed
sameersubudhi
pushed a commit
that referenced
this pull request
Sep 10, 2024
### What was the problem? This PR resolves LISK-912. ### How was it solved? - [x] Execute `installDependencies.sh` script inside `AfterInstall` hook. - [x] Execute scripts inside `appspec.yml` as root. - [x] Use `--frozen-lockfile` for `yarn install` - [x] Read and use node version from `.nvmrc` file ### How was it tested? `installDependencies.sh` script was locally executed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves LISK-912.
How was it solved?
installDependencies.shscript insideAfterInstallhook.appspec.ymlas root.--frozen-lockfileforyarn install.nvmrcfileHow was it tested?
installDependencies.shscript was locally executed